Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #532 by sorting table keys when processing content #974

Merged
merged 4 commits into from
Jul 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/hyphenator-liang.lua
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ local function loadPatterns(hyphenator, language)
print("No patterns for language "..language)
return
end
for _, pattern in pairs(languageset.patterns) do addPattern(hyphenator, pattern) end
for _, pattern in ipairs(languageset.patterns) do addPattern(hyphenator, pattern) end
if not languageset.exceptions then languageset.exceptions = {} end
for _, exception in pairs(languageset.exceptions) do
for _, exception in ipairs(languageset.exceptions) do
registerException(hyphenator, exception)
end
end
Expand Down Expand Up @@ -114,7 +114,7 @@ local hyphenateNode = function (node)
local newnodes = {}
for j, brk in ipairs(breaks) do
if not(brk == "") then
for _, newNode in pairs(SILE.shaper:createNnodes(brk, node.options)) do
for _, newNode in ipairs(SILE.shaper:createNnodes(brk, node.options)) do
if newNode.is_nnode then
newNode.parent = node
table.insert(newnodes, newNode)
Expand Down
8 changes: 4 additions & 4 deletions core/nodefactory.lua
Original file line number Diff line number Diff line change
Expand Up @@ -304,21 +304,21 @@ nodefactory.discretionary = pl.class({
prebreakWidth = function (self)
if self.prebw then return self.prebw end
self.prebw = SILE.length()
for _, node in pairs(self.prebreak) do self.prebw:___add(node.width) end
for _, node in ipairs(self.prebreak) do self.prebw:___add(node.width) end
return self.prebw
end,

postbreakWidth = function (self)
if self.postbw then return self.postbw end
self.postbw = SILE.length()
for _, node in pairs(self.postbreak) do self.pastbw:___add(node.width) end
for _, node in ipairs(self.postbreak) do self.pastbw:___add(node.width) end
return self.postbw
end,

replacementWidth = function (self)
if self.replacew then return self.replacew end
self.replacew = SILE.length()
for _, node in pairs(self.replacement) do self.replacew:___add(node.width) end
for _, node in ipairs(self.replacement) do self.replacew:___add(node.width) end
return self.replacew
end,

Expand Down Expand Up @@ -522,7 +522,7 @@ nodefactory.vbox = pl.class({
outputYourself = function (self, typesetter, line)
typesetter.frame:advancePageDirection(self.height)
local initial = true
for _, node in pairs(self.nodes) do
for _, node in ipairs(self.nodes) do
if not (initial and (node.is_glue or node.is_penalty)) then
initial = false
node:outputYourself(typesetter, line)
Expand Down
19 changes: 18 additions & 1 deletion core/utilities.lua
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,23 @@ utilities.map = function (func, array)
return new_array
end

-- TODO: Replace with pl.tablex.sort()?
utilities.sortedpairs = function (input)
local keys = {}
for k, _ in pairs(input) do
keys[#keys+1] = k
end
table.sort(keys, function(a, b)
if type(a) ~= type(b) then return false end
return a < b
end)
return coroutine.wrap(function()
alerque marked this conversation as resolved.
Show resolved Hide resolved
for i = 1, #keys do
coroutine.yield(keys[i], input[keys[i]])
end
end)
end

utilities.splice = function (array, start, stop, replacement)
local ptr = start
local room = stop - start + 1
Expand Down Expand Up @@ -257,7 +274,7 @@ end
-- items — assuming that the current command is taking care of itself
utilities.subContent = function (content)
local out = { id="stuff" }
for key, val in pairs(content) do
for key, val in utilities.sortedpairs(content) do
if type(key) == "number" then
out[#out+1] = val
end
Expand Down
2 changes: 1 addition & 1 deletion packages/inputfilter.lua
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
local function transformContent(content, transformFunction, extraArgs)
local newContent = {}
for k, v in pairs(content) do
for k, v in SU.sortedpairs(content) do
if type(k) == "number" then
if type(v) == "string" then
local transformed = transformFunction(v, content, extraArgs)
Expand Down