-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat unicode softhyphen support #1935
Feat unicode softhyphen support #1935
Conversation
12de354
to
11bf593
Compare
Any thoughts on a release target for this? v0.14.14? v0.15.0? Let it simmer? |
11bf593
to
bf088bd
Compare
Removed the "Draft" by the way. Looking at the expected results, I realized we could do better (avoiding the string to be split in multiple unshaped tokens when soft hyphens are ignored = so ligatures will work then) and I rebased my earlier version. |
I definitely approve of the direction and as much of the implementation as I see, so document away. Since it isn't a breaking change I'm totally fine with putting it in the next minor release (semver patch level). I'll keep making those occasionally until such a time as v0.15.0 is ready. That still has a bit of baking to do but I'm hoping it won't be too much longer. |
Documentation added in the manual ch. 8, "Hyphenation" section, as a note. |
a04783d
to
f8119d6
Compare
Closes #1930
The proposal described there, with a test.