Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat unicode softhyphen support #1935

Merged

Conversation

Omikhleia
Copy link
Member

Closes #1930

The proposal described there, with a test.

@Omikhleia Omikhleia requested a review from alerque as a code owner December 13, 2023 18:54
@Omikhleia Omikhleia marked this pull request as draft December 13, 2023 19:07
@Omikhleia Omikhleia force-pushed the feat-unicode-softhyphen-support branch from 12de354 to 11bf593 Compare December 13, 2023 19:22
@alerque
Copy link
Member

alerque commented Dec 13, 2023

Any thoughts on a release target for this? v0.14.14? v0.15.0? Let it simmer?

@Omikhleia Omikhleia force-pushed the feat-unicode-softhyphen-support branch from 11bf593 to bf088bd Compare December 13, 2023 19:28
@Omikhleia
Copy link
Member Author

Omikhleia commented Dec 13, 2023

@alerque

Any thoughts on a release target for this? v0.14.14? v0.15.0? Let it simmer?

If deemed acceptable, both #1935 and #1918 (EDIT) need proper documentation and could eventually go in 0.15 -- There's no real urge for them, your call depending on your release schedule!

@Omikhleia Omikhleia added the enhancement Software improvement or feature request label Dec 13, 2023
@Omikhleia Omikhleia marked this pull request as ready for review December 13, 2023 19:35
@Omikhleia
Copy link
Member Author

Omikhleia commented Dec 13, 2023

Removed the "Draft" by the way. Looking at the expected results, I realized we could do better (avoiding the string to be split in multiple unshaped tokens when soft hyphens are ignored = so ligatures will work then) and I rebased my earlier version.

@alerque
Copy link
Member

alerque commented Dec 13, 2023

I definitely approve of the direction and as much of the implementation as I see, so document away. Since it isn't a breaking change I'm totally fine with putting it in the next minor release (semver patch level). I'll keep making those occasionally until such a time as v0.15.0 is ready. That still has a bit of baking to do but I'm hoping it won't be too much longer.

@alerque alerque added this to the v0.14.14 milestone Dec 13, 2023
@Omikhleia
Copy link
Member Author

Documentation added in the manual ch. 8, "Hyphenation" section, as a note.

alerque
alerque previously approved these changes Dec 16, 2023
tests/feat-unicode-softhyphen.sil Outdated Show resolved Hide resolved
@alerque alerque force-pushed the feat-unicode-softhyphen-support branch from a04783d to f8119d6 Compare December 16, 2023 15:21
@alerque alerque merged commit 5a6b3d0 into sile-typesetter:master Dec 16, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Software improvement or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native unicode U+00A9 (soft hyphen) support
2 participants