-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-referencing package #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're 99% of the way towards making this package independent so it doesn't need to touch the class or other packages. Lets get it all the way there before merging. I've spent days recently trying to untangle other packages so they can be used in isolation and/or are idempotent to load. I think that's going to be a requirement for new core packages going forward and this one only needs minor tweaks to get there.
fbf09cb
to
edf4313
Compare
Update: Rebased on current master at this date (7925d45) and upgraded to 0.14 API. Caveat: In the manual, this is not working very well any longer, but for two root causes which IMHO are unrelated:
|
Here, each time a package loads another one on which it is dependent, with |
I am refactoring this as an "external" luarocks package. |
Here it goes https://github.com/Omikhleia/labelrefs.sile |
Rationale for this PR:
(so challenge taken, and I claim the bonus points too ;) )
What this packages proposes:
\label
,\ref
,\pageref
...).If it makes it into the distribution, I intend it as a replacement for my own "omirefs" package (it's the exact same code, the only change here being the documentation, using our new autodoc stuffs).
As for the TOC, it requires one or more re-run(s) of SILE. It doesn't come with tests (until we have a clean way to automate those re-runs), nevertheless, FWIW: