Update the sample output in example/default-metrics.js
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
force-pushed
the
update-sample-output-in-example/default-metrics.js
branch
from
597dd97 to
9392e6a
Compare
|
cc @zbjornson |
|
Gentle ping @zbjornson, in case you missed ^ |
|
Should we rerun with 18 as it's LTS? |
RaisinTen
force-pushed
the
update-sample-output-in-example/default-metrics.js
branch
from
9392e6a to
e087737
Compare
This updates the outdated sample output with the latest one we get when we run the script using Node.js v18.12.1 on an x86_64 Ubuntu 20.04. Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
update-sample-output-in-example/default-metrics.js
branch
from
e087737 to
1e25714
Compare
|
@SimenB good idea, done! |
RaisinTen
deleted the
update-sample-output-in-example/default-metrics.js
branch
rafixer
pushed a commit
to rafixer/prom-client
that referenced
this pull request
Mar 14, 2023
Signed-off-by: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the outdated sample output with the latest one we get when we
run the script using Node.js v18.12.1 on an x86_64 Ubuntu 20.04.
Signed-off-by: Darshan Sen [email protected]