Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various last-minute fixes #229

Merged
merged 5 commits into from
May 31, 2024
Merged

Various last-minute fixes #229

merged 5 commits into from
May 31, 2024

Conversation

pdiakumis
Copy link
Collaborator

@pdiakumis pdiakumis commented May 30, 2024

  • We can use CNAqc::example_dataset_CNAqc to load the example dataset
❯ checking R code for possible problems ... NOTE
  make_cnaqc_object: no visible global function definition for ‘data’
  make_cnaqc_object: no visible binding for global variable
    ‘example_dataset_CNAqc’
  Undefined global functions or variables:
    data example_dataset_CNAqc
  Consider adding
    importFrom("utils", "data")
  to your NAMESPACE file.
  • Installing {openxlsx2} via the new conda setup
  • Exporting strip_html
  • Adding {caret} to the dependencies

@pdiakumis pdiakumis marked this pull request as ready for review May 31, 2024 13:01
@pdiakumis pdiakumis requested a review from sigven May 31, 2024 13:01
Copy link
Owner

@sigven sigven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - getting there=)

@sigven sigven merged commit c84d701 into bundle_update_2023 May 31, 2024
@pdiakumis pdiakumis deleted the pd_fixes branch May 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants