Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping these PRs short.
Functions
xfun::strip_html
from {xfun} and just copied it into {pcgrr} itself to save from an extra dependency.MutationalPatterns:::.resample_mut_mat
since that's an unexported function from {MutationalPatterns}.match_eitems_to_var
is commented out inpcgrr/biomarkers.R
since it's deprecated. But it's called inget_clin_assocs_snv_indel
(also inpcgrr/biomarkers.R
) so I've commented that out as well.:::
inside other {pcgrr} code e.g.pcgrr:::load_expression_similarity
can simply becomeload_expression_similarity
.tibble::has_name
can becomerlang::has_name
and save from requiring the {tibble} dependency.DESCRIPTION Dependencies
Removed the following since I couldn't see where they were used in the source code:
Added following: