Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from devtools::check #225

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

pdiakumis
Copy link
Collaborator

Keeping these PRs short.

Functions

  • Grabbed the source of xfun::strip_html from {xfun} and just copied it into {pcgrr} itself to save from an extra dependency.
  • Did the same for MutationalPatterns:::.resample_mut_mat since that's an unexported function from {MutationalPatterns}.
  • match_eitems_to_var is commented out in pcgrr/biomarkers.R since it's deprecated. But it's called in get_clin_assocs_snv_indel (also in pcgrr/biomarkers.R) so I've commented that out as well.
  • You can refer to {pcgrr} unexported functions without the ::: inside other {pcgrr} code e.g. pcgrr:::load_expression_similarity can simply become load_expression_similarity.
  • tibble::has_name can become rlang::has_name and save from requiring the {tibble} dependency.

DESCRIPTION Dependencies

  • Removed the following since I couldn't see where they were used in the source code:

    • BiocGenerics
    • caret
    • ggpubr
    • IRanges
    • randomForest
    • usethis (this is only for dev + data-raw)
  • Added following:

    • cpsr
    • CNAqc
    • readr
    • stringi

@pdiakumis pdiakumis requested a review from sigven April 30, 2024 07:23
@sigven
Copy link
Owner

sigven commented Apr 30, 2024

All sensible edits, some old dependencies (IRanges) coming from previous CNA annotation routine. caret and randomForest are also not necessary, msi.R only uses stats::predict on an existing prediction model, I think that should work.

@sigven sigven merged commit 6d6039e into sigven:bundle_update_2023 Apr 30, 2024
@pdiakumis pdiakumis deleted the bundle_update_2023_PD branch April 30, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants