Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cosigned docs with new ClusterImagePolicy usage #147

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

DennyHoang
Copy link

Summary

Add supporting documentation on ClusterImagePolicy configuration and usage.

Ticket Link

Addressing #139

Release Note

* Added documentation for ClusterImagePolicy configuration and usage

add keyless, remote signatures, tlog info

Signed-off-by: Denny Hoang <[email protected]>
@netlify
Copy link

netlify bot commented Apr 21, 2022

Deploy Preview for sigstore ready!

Name Link
🔨 Latest commit ee000bb
🔍 Latest deploy log https://app.netlify.com/sites/sigstore/deploys/6266d58eb1e214000891c953
😎 Deploy Preview https://deploy-preview-147--sigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!!!

content/en/cosign/kubernetes.md Outdated Show resolved Hide resolved
content/en/cosign/kubernetes.md Outdated Show resolved Hide resolved
content/en/cosign/kubernetes.md Outdated Show resolved Hide resolved
content/en/cosign/kubernetes.md Outdated Show resolved Hide resolved
content/en/cosign/kubernetes.md Show resolved Hide resolved
content/en/cosign/kubernetes.md Show resolved Hide resolved
content/en/cosign/kubernetes.md Outdated Show resolved Hide resolved
@DennyHoang
Copy link
Author

Addressed PR comments:

  • Fixed grammar
  • Added Depcreated Cosigned Verification Behavior Section
  • Moved Enable Cosigned Admission Controller for Namespaces section to kubernetes.md and have it linked from installation.md instead
  • added "no policy matched" scenario to section Admission of Images
  • Mentioned currently only supporting ECDSA keys

cc: @vaikas

@DennyHoang DennyHoang marked this pull request as ready for review April 25, 2022 17:11
Copy link

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this! I'll take a crack at adding documentation for attestations. I'm at an offsite this week though, so will be a bit slower than usual.

Copy link

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DennyHoang Thanks :).
Could you add the last properties added to the CIP e.g. policy ...?

@DennyHoang
Copy link
Author

@hectorj2f I have not gotten familiar with the new CIP policy attestation fields yet. So I would prefer adding that documentation in a different PR.

@dlorenc dlorenc merged commit f0e0cd3 into sigstore:docs Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants