Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /api/v1/index/retrieve endpoint from prober checks since it's experimental #340

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

priyawadhwa
Copy link
Contributor

ref sigstore/rekor#1021

cc @bobcallaway

Signed-off-by: Priya Wadhwa [email protected]

@haydentherapper
Copy link
Contributor

I had brought this up a while ago, but can we differentiate between critical prober alerts that should result in pages and ones that should result in tickets? I think we should still have visibility into the search API, but it doesn't need to trigger a page.

@priyawadhwa
Copy link
Contributor Author

can we differentiate between critical prober alerts that should result in pages and ones that should result in tickets

I'm not sure, I don't think GCP let's you differentiate between alerts so it would have to be done in PagerDuty.

For now I can keep the endpoint data but turn off the alert on this endpoint?

haydentherapper
haydentherapper previously approved these changes Sep 8, 2022
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a comment in the prober config that it does not generate an alert?

@priyawadhwa priyawadhwa requested a review from vaikas September 8, 2022 20:10
@vaikas
Copy link
Contributor

vaikas commented Sep 8, 2022

@priyawadhwa I think you might need to update the ko?

- uses: imjasonh/[email protected]
   with:
       version: v0.12.0

Could've sworn there were some screwiness that resulted in badness and it looks like things have failed twice?

@vaikas
Copy link
Contributor

vaikas commented Sep 8, 2022

LOL :) You already did it :)

@vaikas vaikas enabled auto-merge (squash) September 9, 2022 16:17
@vaikas vaikas merged commit bdd0b4c into sigstore:main Sep 9, 2022
@priyawadhwa priyawadhwa deleted the rekor-retrieve branch September 9, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants