parser: Handle custom roles #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser appends results from each yaml unmarshall separately for each toplevel yaml field: This was missing for customRoles. * Append unmarshalled customRoles to config * Also make the toplevel name uniformly "customRoles": no need to use two different names Signed-off-by: Jussi Kukkonen <[email protected]>
|
CC @cpanato if you want to have a look |
cpanato
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser appends results from each unmarshalled yaml separately for each toplevel yaml field: This was missing for customRoles in my earlier PR #117 .
This should fix the failure in sigstore/community#395 (although I will have to change the field name there as well).