Fix two bugs in the pivkey code related to cleanup and certs. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The card management was refactored a bit so we can't just defer a close on the key itself, we need to move this up to the Signer. There was also an errant break statement causing a fallback in our switch. Signed-off-by: Dan Lorenc <[email protected]>
dekkagaijin
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The card management was refactored a bit so we can't just defer a close on
the key itself, we need to move this up to the Signer.
There was also an errant break statement causing a fallback in our switch.
Fixes #887
Signed-off-by: Dan Lorenc [email protected]
Summary
Ticket Link
Fixes
Release Note