Replace predicate file path with io.Reader #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per a discussion with @dekkagaijin, this PR makes an incremental change to help consumers of cosign's attestation functions, specifically by allowing the caller of
attestation.GenerateStatementto provide anyio.Readerimplementation as the statement's predicate, rather than having the caller provide a file path. This allows consumers to control the source of the predicate bytes, which is particularly valuable for non-file predicate sources, such as bytes existing only in memory.Ticket Link
(Takes one step forward on #844)
Release Note