Try out Attestations()
#779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs loads of changes (e.g. unit test coverage), and is based on another unmerged change, but I wanted to see whether it passed the e2e tests 🤞 |
mattmoor
force-pushed
the
try-out-attestation-accessor
branch
from
1791270 to
b2c8767
Compare
I know I just killed this off for being NYI, but I don't like the fact that we need `WithSignatureSuffix` to access things. Related: sigstore#666 Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
try-out-attestation-accessor
branch
from
b2c8767 to
40f3d01
Compare
|
Ok, this should have unit test coverage, so I am going to remove the WIP. For my next change, I'm going to look at sorting out the |
dekkagaijin
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I just killed this off for being NYI, but I don't like the fact that we need
WithSignatureSuffixto access things.Ticket Link
Related #666
Release Note