Migrate SignCmd to several new helpers.
#764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holy shit! First Try 😎 |
This change eliminates a whole bunch of the ad hoc index walking logic in favor of `mutate.Map`, and a handful of new library calls that let us attach a new signature, and then publish those signature. This detailed comment lays out the plan: sigstore#666 (comment), and this is very nearly what the code ended up being. Related: sigstore#666 Signed-off-by: Matt Moore <[email protected]>
mattmoor
changed the title
SignCmd to several new helpers.SignCmd to several new helpers.
|
I think I'll add a "read only" |
dekkagaijin
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates a whole bunch of the ad hoc index walking logic in favor of
mutate.Map, and a handful of new library calls that let us attach a new signature, and then publish those signature.This detailed comment lays out the plan: #666 (comment), and this is very nearly what the code ended up being.
Signed-off-by: Matt Moore [email protected]
WIP until #763 lands. There is no way this is going to "just work" either, or I am going to throw some lego batman videos at y'all.
Ticket Link
Related: #666
Release Note