Add mutate.SignEntity and friends.
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
mutate-sign-entity
branch
from
9ec7548 to
b35f935
Compare
These mutators attach a new `oci.Signature` to the `oci.Signatures` hanging off of an `oci.SignedEntity`. A `DupeDetector` may optionally be passed via functional options, to elide the signature when a "dupe" already exists. Related: sigstore#666 Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
mutate-sign-entity
branch
from
b35f935 to
f5cfe48
Compare
dekkagaijin
approved these changes
Sep 23, 2021
internal/oci/mutate/mutate.go
Outdated
| @@ -121,3 +122,81 @@ func (i *indexWrapper) SignedImageIndex(h v1.Hash) (oci.SignedImageIndex, error) | |||
| return signed.ImageIndex(unsigned), nil | |||
| } | |||
| } | |||
|
|
|||
| // SignEntity attaches the provided signature to the provided entity. | |||
| func SignEntity(se oci.SignedEntity, sig oci.Signature, opts ...SignOption) (oci.SignedEntity, error) { | |||
There was a problem hiding this comment.
Let's replace things like SignFoo with AttachSignatureToFoo (or something) to avoid confusing these with the objects doing cryptographic operations. Think that "sign" conceptual space is already crowded enough in this library ecosystem
There was a problem hiding this comment.
Sure, I like the Attach nuance. Let me just battle merge conflicts for a while 😉
| @@ -108,7 +103,7 @@ LayerLoop: | |||
| } | |||
|
|
|||
| type UploadOpts struct { | |||
| DupeDetector DupeDetector | |||
| DupeDetector mutate.DupeDetector | |||
| RemoteOpts []remote.Option | |||
There was a problem hiding this comment.
I know this was already here, but let's also standardize on clientOpts or registryClientOpts when we come across these to improve descriptiveness
There was a problem hiding this comment.
I can follow up to clean some of this stuff up
Signed-off-by: Matt Moore <[email protected]>
dekkagaijin
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mutators attach a new
oci.Signatureto theoci.Signatureshanging off of anoci.SignedEntity.A
DupeDetectormay optionally be passed via functional options, to elide the signature when a "dupe" already exists.Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: #666
Release Note