Migrate image.Digest to ociremote.ResolveDigest.
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
retire-image-dot-digest
branch
from
092128a to
89ee7d4
Compare
The only thing left in `pkg/image` was `Digest`, which potentially hits `remote.Get`. This change introduces `ociremote.ResolveDigest`, which is similar, but takes our options and returns a `name.Digest` instead of a `v1.Hash`. Related: sigstore#666 Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
retire-image-dot-digest
branch
from
89ee7d4 to
6cc3986
Compare
dekkagaijin
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing left in
pkg/imagewasDigest, which potentially hitsremote.Get.This change introduces
ociremote.ResolveDigest, which is similar, but takes our options and returns aname.Digestinstead of av1.Hash.Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: #666
Release Note