Make UploadSignature take an oci.Signature.
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have `static.NewSignature`, this shifts the construction out of `UploadSignature` and removes the elements passed via `UploadOpts` to simply be a part of the `NewSignature` call on the caller's side. With this `UploadSignature` is starting to look pretty lean! Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
upload-signature
branch
from
7ce0651 to
29ac2ad
Compare
dekkagaijin
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
static.NewSignature, this shifts the construction out ofUploadSignatureand removes the elements passed viaUploadOptsto simply be a part of theNewSignaturecall on the caller's side.With this
UploadSignatureis starting to look pretty lean!Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: #666
Release Note