Add Annotations to oci.Signature.
#741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has two main parts, the first is largely as the title indicates, which is to add an `Annotations()` method to `oci.Signature` (and our implementations thereof). This is largely motivated by the second half of this change. The second part of this change is starting to orient `UploadSignature` to operate in terms of our `oci` interfaces. For a much longer-form version of the direction I'd like to drive this towards, see here: sigstore#666 (comment). This is a bit messier than I'd like, but I think it is progress towards the final form outlined in the issue since it starts to orient things like deduplication around the `oci.Signature` interface. Related: sigstore#666 Signed-off-by: Matt Moore <[email protected]>
|
nice issue number |
|
Looks like I broke something about signature deduplication. 😅 |
mattmoor
force-pushed
the
implement-signature
branch
from
5842a5c to
8229e66
Compare
|
Ah, this was an easy fix. Because the |
Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
implement-signature
branch
from
8229e66 to
b45831e
Compare
|
It looks like the e2e tests expect the caller to have put |
dekkagaijin
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has two main parts, the first is largely as the title indicates, which is to add an
Annotations()method tooci.Signature(and our implementations thereof). This is largely motivated by the second half of this change.The second part of this change is starting to orient
UploadSignatureto operate in terms of ourociinterfaces. For a much longer-form version of the direction I'd like to drive this towards, see here: #666 (comment). This is a bit messier than I'd like, but I think it is progress towards the final form outlined in the issue since it starts to orient things like deduplication around theoci.Signatureinterface.Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: Related: #666
Release Note