Start to build up a mutate package.
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet used, but start to lay out some useful utilities for walking over and manipulating Images and Indices. The first bit is `mutate.AppendManifests`, which builds around the utility with the same name in GGCR. This utility produces an `oci.SignedImageIndex`, where (because of the mutation) the signatures are necessarily empty, but which provides access to the signatures of the entities contained within it. This was mostly useful for constructing images for tests. The second bit is `mutate.Map`, which surfaces a way to apply a `Mutator` function to the `oci.SignedEntity`s contained within a particular `oci.SignedEntity`. Notable features: * `Mutator`s can control whether they descend into the children of indices (useful for recursive signing or signature verification). * `Mutator`s can filter entities by returning `nil` without `error`. * `Mutator`s are called before and (if changed) after its children are walked, which is detectable via helpers on `ctx`. * `Mutator`s can return their input entity if they are just a simple readonly walk. Signed-off-by: Matt Moore <[email protected]>
dekkagaijin
reviewed
Sep 20, 2021
|
|
||
| // before decorates the context such that IsBeforeChildren(ctx) is true. | ||
| func before(ctx context.Context) context.Context { | ||
| return context.WithValue(ctx, mapPassKey{}, "before") |
There was a problem hiding this comment.
turn "before" and "after" into consts and/or enums?
There was a problem hiding this comment.
I was going to say "but I'll just call them before/after", but I can't because that's what the methods are called. 🙃
Given the proximity of the functions, and the tests to make sure they agree, I'm sort of inclined to leave it 😅
Signed-off-by: Matt Moore <[email protected]>
dekkagaijin
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet used, but start to lay out some useful utilities for walking over and manipulating Images and Indices.
The first bit is
mutate.AppendManifests, which builds around the utility with the same name in GGCR. This utility produces anoci.SignedImageIndex, where (because of the mutation) the signatures are necessarily empty, but which provides access to the signatures of the entities contained within it. This was mostly useful for constructing images for tests.The second bit is
mutate.Map, which surfaces a way to apply aMutatorfunction to theoci.SignedEntitys contained within a particularoci.SignedEntity. Notable features:Mutators can control whether they descend into the children of indices (useful for recursive signing or signature verification).Mutators can filter entities by returningnilwithouterror.Mutators are called before and (if changed) after its children are walked, which is detectable via helpers onctx.Mutators can return their input entity if they are just a simple readonly walk.Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: #666
Release Note