Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cert chain validation for verify-blob in non-experimental mode #2256

Merged
merged 5 commits into from
Sep 16, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
Signed-off-by: Asra Ali <[email protected]>
asraa committed Sep 15, 2022
commit 0a2e6e7421131c4b53450ebc3c40f61f425262c2
4 changes: 2 additions & 2 deletions cmd/cosign/cli/verify/verify_blob_test.go
Original file line number Diff line number Diff line change
@@ -1038,7 +1038,7 @@ func TestVerifyBlobCmdInvalidRootCA(t *testing.T) {
keyless := newKeylessStack(t)
// Change the keyless stack.
_ = newKeylessStack(t)
t.Run("Invalid certificate root explicit certRef", func(t *testing.T) {
t.Run("Invalid certificate root when specifying cert via certRef", func(t *testing.T) {
identity := "[email protected]"
issuer := "issuer"
leafCert, _, leafPemCert, signer := keyless.genLeafCert(t, identity, issuer)
@@ -1077,7 +1077,7 @@ func TestVerifyBlobCmdInvalidRootCA(t *testing.T) {
t.Fatalf("expected error with invalid root CA, got %v", err)
}
})
t.Run("Invalid certificate root explicit bundle", func(t *testing.T) {
t.Run("Invalid certificate root when specifying cert in bundle", func(t *testing.T) {
identity := "[email protected]"
issuer := "issuer"
leafCert, _, leafPemCert, signer := keyless.genLeafCert(t, identity, issuer)