add fulcio.DSSEAttestor
#1226
Closed
add fulcio.DSSEAttestor
#1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Dec 16, 2021
| return nil, nil, err | ||
| } | ||
|
|
||
| // TODO(dekkagaijin): move the fulcio SignerVerififer logic here |
There was a problem hiding this comment.
Can we just do this?
I feel like we keep rehashing the argument about fulcio being a wrapper 😉
There was a problem hiding this comment.
I would, but doing that involves changing everything
There was a problem hiding this comment.
Only if you use it right? We talked about forking chunks of logic over here and then replacing the spaghetti monster with the composable blocks 😇
There was a problem hiding this comment.
fair, I'll migrate things over for the Attestor
Signed-off-by: Jake Sanders <[email protected]>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to create a
Attestorequivalent for the eventual upstream splitting ofSigningandAttesting.Ticket Link
#844 #931
Release Note