ps2: Added ps2 mouse example #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Included PR #39 |
fenugrec
reviewed
Sep 28, 2023
There was a problem hiding this comment.
I like the explanations in the README.
- signal labels
- readme
- test suite PR linked : sigrok-test#21
- general structure [ok after last push]
I think some of the commits should be reworked and squashed :
- avoid creating a file that is immediately replaced (the microsoft mouse capture, I believe)
- avoid creating the misplaced file (from PR ps2 mouse initialize_and_move #39) just to move it immediately after. I think this file+file rename can be squashed cleanly while retaining commit authorship of @Jaybee-
1 second at 1MHz.
Initialize a ps2 mouse, configure it; the mouse then reports movement data.
- host resets device, waits for reset to complete
- host sets sample rate to 200, 100, 80 - this activates reporting scroll wheel data is available
- host sets device to maximum sample rate: 200; resolution=1: 2 count/mm; 1:1 scaling, stream mode
- host gets device id, enable data reporting
- after a delay, the mouse is moved, and reports it's changing location, in sequences of 4 bytes:
- flags, x movement, y movement, z (scroll wheel) movement.
- the sample data does not include any button presses or scroll wheel movement
- Added example of host-to-mouse configuration and mouse-to-host movement packets - Updated README
|
@fenugrec Thanks for the guidance. I have squashed into two clean commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example of host-to-mouse configuration and mouse-to-host movement packets