Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly toggle urbanisme tool when another drawing tool is activated #54

Merged
merged 10 commits into from
May 17, 2022
Merged

Properly toggle urbanisme tool when another drawing tool is activated #54

merged 10 commits into from
May 17, 2022

Conversation

alexander-fedorenko
Copy link
Collaborator

@alexander-fedorenko alexander-fedorenko commented May 12, 2022 •
edited
Loading

This PR provides set of changes on the urbanisme extension side to properly toggle its status according to the selected drawing tool. See georchestra/mapstore2-georchestra#530 as a reference

Following rules are applied:

  • Urbanisme tool toggled off - modal with info properly deactivated.
  • Annotation coordinate editor open: urbanisme tool toggled off.
  • Measure activated: urbanisme tool toggled off
  • Street View activated: urbanisme tool toggled off.
  • Cadastrapp selection tool activated: urbanisme tool toggled off.
  • Feature editor activated: urbanisme tool toggled off.
  • Layer filter - drawing of the area for filter is active, urbanisme tool toggled off.

@alexander-fedorenko alexander-fedorenko self-assigned this May 12, 2022
@alexander-fedorenko alexander-fedorenko mentioned this pull request May 12, 2022
Closed
@tdipisa tdipisa requested review from allyoucanmap and removed request for tdipisa May 13, 2022 08:24
@alexander-fedorenko
Urbanisme tool will be deactivated whenever another drawing tool is o…
8239d7b 
…pen.

Do not purgeMapinfoResults because it forces annotation edit mode to close.
@alexander-fedorenko
Amending test
028ed63
@alexander-fedorenko
Copy link
Collaborator Author

Applied simplified and improved logic of toggling urbanisme tools off whenever another tool starts drawing interaction.
@allyoucanmap ready for review

@allyoucanmap allyoucanmap merged commit 438fd11 into sigrennesmetropole:master May 17, 2022
@alexander-fedorenko alexander-fedorenko mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@alexander-fedorenko alexander-fedorenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fedorenko @allyoucanmap