Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40: Localization added for help button #41

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

dsuren1
Copy link
Collaborator

@dsuren1 dsuren1 commented Jan 10, 2022

Description

This PR adds localization data added for help button

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#40

What is the new behavior?
Help button displays correct translation text as tooltip

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 requested a review from offtherailz January 10, 2022 12:46
@dsuren1 dsuren1 self-assigned this Jan 10, 2022
@@ -13,8 +13,7 @@ export const DEFAULT_CADASTRAPP_URL = "/cadastrapp/services";
export const DEFAULT_URBANISMEAPP_URL = "/urbanisme";
export const URBANISME_TOOLS = {
NRU: "NRU",
ADS: "ADS",
HELP: "HELP"
ADS: "ADS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused constant

Copy link
Collaborator

@MaelREBOUX MaelREBOUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made 2 comments

@offtherailz offtherailz merged commit 825278a into sigrennesmetropole:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants