-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#40: Localization added for help button #41
Conversation
@@ -13,8 +13,7 @@ export const DEFAULT_CADASTRAPP_URL = "/cadastrapp/services"; | |||
export const DEFAULT_URBANISMEAPP_URL = "/urbanisme"; | |||
export const URBANISME_TOOLS = { | |||
NRU: "NRU", | |||
ADS: "ADS", | |||
HELP: "HELP" | |||
ADS: "ADS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unused constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made 2 comments
Description
This PR adds localization data added for help button
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#40
What is the new behavior?
Help button displays correct translation text as tooltip
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information