Subscribe to PeerDAS topics on Fulu fork #6849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
dapplion
force-pushed
the
peerdas-topics-fulu
branch
from
2150988 to
385b061
Compare
jxs
reviewed
Jan 27, 2025
| @@ -183,6 +184,14 @@ impl<E: EthSpec> NetworkGlobals<E> { | |||
| .collect::<Vec<_>>() | |||
| } | |||
|
|
|||
| /// Returns the TopicConfig to compute the set of Gossip topics for a given fork | |||
| pub fn topic_config(&self) -> TopicConfig { | |||
There was a problem hiding this comment.
we can avoid double iteration by not collection bellow into a Vec and just using a reference to Hashset.
fork_core_topics can still iterate the sampling_subnets normally, see jxs@09c5f6f if you want to cherry pick the commit.
notice the as_topic_config as code convention
There was a problem hiding this comment.
Thanks! cherry-picked
jimmygchen
reviewed
Jan 31, 2025
| }; | ||
| let mut electra_core_topics = | ||
| fork_core_topics::<E>(&ForkName::Electra, &spec, &topic_config); | ||
| let mut deneb_core_topics = fork_core_topics::<E>(&ForkName::Deneb, &spec, &topic_config); |
There was a problem hiding this comment.
can we add fulu_core_topics too to cover the new changes?
There was a problem hiding this comment.
Added fulu_core_topics
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
jimmygchen
requested changes
Jan 31, 2025
jimmygchen
added
waiting-on-author
dapplion
force-pushed
the
peerdas-topics-fulu
branch
from
385b061 to
43ae790
Compare
dapplion
added
ready-for-review
jimmygchen
added
ready-for-merge
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
TODO(das)now that PeerDAS is scheduled in a hard fork we can subscribe to its topics on the fork activation. In current stable we subscribe to PeerDAS topics as soon as the node starts if PeerDAS is scheduled.This PR adds another todo to unsubscribe to blob topics at the fork. This other PR included solution for that, but I can include it in a separate PR
Proposed Changes
Include PeerDAS topics as part of Fulu fork in
fork_core_topics.