Refactor mock builder #6735
Open
Refactor mock builder #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
force-pushed
the
refactor-mock-builder
branch
from
80f1d42 to
91c1cf9
Compare
pawanjay176
force-pushed
the
refactor-mock-builder
branch
from
c185184 to
8c93b11
Compare
pawanjay176
added
ready-for-review
realbigsean
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Excellent work
So you know I have axum implemented for this api here, we can add this later though
https://github.com/sigp/ethereum_apis/blob/main/builder-server/src/server.rs
edit: nevermind you're already using it 😂
pawanjay176
force-pushed
the
refactor-mock-builder
branch
from
5e22c79 to
1f7b4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Adds electra support to the builder flow.
Refactor the mock builder to extract all builder functions into separate functions.
Also adds a
prepare_execution_layermethod that prepares the execution layer for payload creation for each slot.The motivation is to provide a backend for a simple builder service that follows the builder api and produces execution payloads from the local mempool of the connected EL. This allows us to have a faster turnaround for testing changes to the builder api in kurtosis testnets and new fork devnets.
See https://github.com/pawanjay176/rustic-builder/
Additional info
The default parameters to the
MockBuilder::new_for_testingproduces a MockBuilder with same functionality as before, so the tests in lighthouse should work as before