-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple eth2
from store
and lighthouse_network
#6680
base: unstable
Are you sure you want to change the base?
Conversation
|
Co-authored-by: Pawan Dhananjay <[email protected]>
7f33d35
to
903bae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this Daniel. Left a couple comments that may help not use serde_json::Value
@jxs, applied the changes we discussed, feel free to take a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Daniel, thanks!
Issue Addressed
Proposed Changes
Remove dependencies on
store
andlighthouse_network
frometh2
. This was achieved as follows:enr
andmultiaddr
directly instead of usinglighthouse_network
's reexports.lighthouse_network
responsible for converting between API and internal types.serde_json::Value
instead - this is not ideal, but should be fine for now, as this affects two internal non-spec endpoints which are meant for debugging, unstable, and subject to change without notice anyway. Inspired by Remove lighthouse_network dependency from eth2 crate #6679. The alternative is to move all relevant types toeth2
ortypes
instead - what do you think?Additional Info
In my opinion, this only partially fixes the issue above, as we probably still should split out lighthouse-specific features.