Deprecate eth1 and dummy-eth1 flags

[michaelsproul]

Proposed Changes

Deprecate the following beacon node flags:

• --eth1: No longer required because it is enabled by default. The deposit contract sync can be disabled via a separate flag --disable-deposit-contract-sync, which has existed since the merge.
• --dummy-eth1: Very rarely used and of limited utility.

[eserilev]

nit

lighthouse/beacon_node/src/config.rs

Lines 285 to 294 in d10e81a

	// Always follow the deposit contract when there is an execution endpoint.
	//
	// This is wasteful for non-staking nodes as they have no need to process deposit contract
	// logs and build an "eth1" cache. The alternative is to explicitly require the `--eth1` or
	// `--staking` flags, however that poses a risk to stakers since they cannot produce blocks
	// without "eth1".
	//
	// The waste for non-staking nodes is relatively small so we err on the side of safety for
	// stakers. The merge is already complicated enough.
	client_config.sync_eth1_chain = true;

since sync_eth1_chain is now true by default, I think this line is redundant. Also the comments about the deprecated --eth-1 flag might no longer be relevant.

EDIT:

also this line here may be redundant

lighthouse/beacon_node/src/config.rs

Line 124 in d10e81a

client_config.sync_eth1_chain = true;

[michaelsproul]

Nice catch, thanks @eserilev. I've removed that redundant code and also added a conflicts_with for --staking and --disable-deposit-contract-sync. Other than the conflicts_with clause, staking is basically identical to http now, but this may not remain the case forever, and I think our users appreciate this flag.

[eserilev]

LGTM!

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c5007ea