You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blst library's verify_multiple_aggregate_signatures function already spreads the verification across multiple cores, we are doing redundant parallelization in lighthouse.
This PR just calls the blst function directly without doing any additional parralelization.
I'm guessing we did this when we were also using milagro bls as it presumably didn't parallelize, but now that we exclusively use blst, this is not needed anymore.
Additional info
This PR need not necessarily be in 5.2.1, we can get some additional long term testing for this to check it doesn't result in performance degradation somehow.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
🛑 The pull request has been removed from the queue default
The queue conditions cannot be satisfied due to failing checks.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
ready-for-mergeThis PR is ready to merge.v5.3.0Q3 2024 release with database changes!
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
michaelsproul
added
ready-for-merge
Issue Addressed
N/A
Proposed Changes
The blst library's
verify_multiple_aggregate_signaturesfunction already spreads the verification across multiple cores, we are doing redundant parallelization in lighthouse.This PR just calls the blst function directly without doing any additional parralelization.
I'm guessing we did this when we were also using milagro bls as it presumably didn't parallelize, but now that we exclusively use blst, this is not needed anymore.
Additional info
This PR need not necessarily be in 5.2.1, we can get some additional long term testing for this to check it doesn't result in performance degradation somehow.