Undo some CLI flag breakages #5902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
val-client
|
looks good to me! |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 947e2e8 |
jxs
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The clap upgrade introduced a few hard breaking changes without deprecation warnings:
Proposed Changes
We've had users be caught out by these sorts of breakages in the past, so I've removed the hard breaking changes for two of the flags more likely to be in use:
--slasher-broadcastand--latency-measurement-service:--slasher-broadcastwithout args is no longer deprecated. It works usingdefault_missing_value, even if we ignoreclap's advice about using.require_equals(true). We may need to change this or deprecate this in future. I couldn't work out at a glance how to tell whether the flag was provided with no value in order to deprecate just that usage. So I figure we may as well keep it for now with no deprecation.--latency-measurement-serviceis readded but is deprecated (and hidden). Lighthouse logs a warning if it is provided, rather than failing to start.