Increase slog buffer size #5882
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1b7c4a4 |
This was referenced Jun 4, 2024
michaelsproul
added a commit
that referenced
this pull request
Jun 4, 2024
Squashed commit of the following: commit d6dfcc4 Author: Michael Sproul <[email protected]> Date: Tue Jun 4 10:36:27 2024 +1000 Increase slog buffer size
Merged
8 tasks
|
Why 16k and not more? What's the avg size of a log record? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Increase the
slogbuffer size to 16K to reduce the occurrence of:These errors sometimes occur on our Holesky BNs which are receiving attestations from 100K validators each. They also occur occasionally on other BNs supporting large numbers of validators.
Examples of messages that overflow the channel include:
DEBG Attempted to publish duplicate messageINFO Started monitoring validatorDEBG Unable to obtain indexed form of attestation for slasher(reduced by InvestigateUnknownTargetRootslasher errors #5006)Arguably some of these should be debounced, but for others it's not obvious that they should be. Increasing the buffer size temporarily at least gives us a full view of the logs until some of these spammier logs are toned down. It's frustrating to miss important ERRO/CRIT logs due to overflows.
Additional Info