Do not double log uknown lookup #5837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
commented
May 24, 2024
| @@ -625,7 +625,11 @@ impl<T: BeaconChainTypes> BlockLookups<T> { | |||
| /// dropped. | |||
| pub fn drop_lookup_and_children(&mut self, dropped_id: SingleLookupId) { | |||
| if let Some(dropped_lookup) = self.single_block_lookups.remove(&dropped_id) { | |||
| debug!(self.log, "Dropping child lookup"; "id" => ?dropped_id, "block_root" => ?dropped_lookup.block_root()); | |||
| debug!(self.log, "Dropping lookup"; | |||
There was a problem hiding this comment.
Instead of labeling this as "child", log if it's awaiting_parent
realbigsean
approved these changes
May 24, 2024
realbigsean
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f1f1250 |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Minor purely log fix. If sync attempts to process an event for an unknown lookup it will log "Dropping child lookup" which is not true. If the lookup is unknown it can't be dropped.
Noticed in #5833
Proposed Changes
Do not double log uknown lookup