-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deneb fork epoch for Gnosis #5242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
work-in-progress
PR is a work-in-progress
and removed
ready-for-review
The code is ready for review
labels
Feb 15, 2024
realbigsean
reviewed
Feb 15, 2024
common/eth2_network_config/built_in_network_configs/gnosis/config.yaml
Outdated
Show resolved
Hide resolved
I think CI's failing because the default here is 4096 but it should be 16384 https://github.com/sigp/lighthouse/blob/stable/consensus/types/src/chain_spec.rs#L957C1-L957C84 |
…fig.yaml Co-authored-by: realbigsean <[email protected]>
paulhauner
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Feb 17, 2024
paulhauner
added a commit
that referenced
this pull request
Feb 18, 2024
Squashed commit of the following: commit 1422de9 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:44:04 2024 +1100 Fix chain spec values again commit d61d53b Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:25:43 2024 +1100 Fix chain spec `max_per_epoch_activation_churn_limit` commit 32b349e Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:08:24 2024 +1100 Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT` commit 8548506 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:01:37 2024 +1100 Adjust `min_epochs_for_block_requests` commit 3305c10 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 19:59:43 2024 +1100 Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml Co-authored-by: realbigsean <[email protected]> commit ca10127 Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:09:50 2024 +1100 Add deneb constants commit 94285cf Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:06:32 2024 +1100 Add Deneb fork epoch for Gnosis
Merged
paulhauner
added a commit
that referenced
this pull request
Feb 18, 2024
Squashed commit of the following: commit 1422de9 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:44:04 2024 +1100 Fix chain spec values again commit d61d53b Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:25:43 2024 +1100 Fix chain spec `max_per_epoch_activation_churn_limit` commit 32b349e Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:08:24 2024 +1100 Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT` commit 8548506 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:01:37 2024 +1100 Adjust `min_epochs_for_block_requests` commit 3305c10 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 19:59:43 2024 +1100 Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml Co-authored-by: realbigsean <[email protected]> commit ca10127 Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:09:50 2024 +1100 Add deneb constants commit 94285cf Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:06:32 2024 +1100 Add Deneb fork epoch for Gnosis
dapplion
approved these changes
Feb 18, 2024
paulhauner
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Feb 18, 2024
paulhauner
added a commit
that referenced
this pull request
Feb 18, 2024
Squashed commit of the following: commit 1422de9 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:44:04 2024 +1100 Fix chain spec values again commit d61d53b Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:25:43 2024 +1100 Fix chain spec `max_per_epoch_activation_churn_limit` commit 32b349e Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:08:24 2024 +1100 Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT` commit 8548506 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 20:01:37 2024 +1100 Adjust `min_epochs_for_block_requests` commit 3305c10 Author: Paul Hauner <[email protected]> Date: Fri Feb 16 19:59:43 2024 +1100 Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml Co-authored-by: realbigsean <[email protected]> commit ca10127 Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:09:50 2024 +1100 Add deneb constants commit 94285cf Author: Paul Hauner <[email protected]> Date: Thu Feb 15 19:06:32 2024 +1100 Add Deneb fork epoch for Gnosis
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e22c9ee |
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5229
Proposed Changes
Adds the Deneb fork epoch as per gnosischain/specs#36.
Additional Info
NA