Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused js file in Lighthouse book #5164

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Remove unused js file in Lighthouse book.

The usage of this deposit file was removed in #1742, and is no longer used anywhere in the Lighthouse book.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Jan 31, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowee, that's an old one!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 2, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 5, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5164 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio dequeue

Copy link

mergify bot commented Feb 5, 2024

dequeue

✅ The pull request has been removed from the queue default

@realbigsean
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 5, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 5, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@realbigsean
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 5, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 5, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 795c577

@mergify mergify bot merged commit 795c577 into sigp:unstable Feb 6, 2024
30 checks passed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
* Remove unused js file in Lighthouse book.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants