Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase attestation cache sizes #5135

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Increase attestation cache sizes #5135

merged 2 commits into from
Jan 30, 2024

Conversation

realbigsean
Copy link
Member

Issue Addressed

Resolves #5134

Proposed Changes

  • Increases the observed aggregates cache size from slots_per_epoch to 2 * slots_per_epoch
  • Increases the observed attesters and observed aggregators cache sizes. This needed to be bumped from 3 epochs to 4 to account for gossip clock disparity on top of the new 2 epoch range of valid attestations.

@realbigsean realbigsean added bug Something isn't working ready-for-review The code is ready for review deneb v5.0.0 Q1 2024 labels Jan 29, 2024
michaelsproul
michaelsproul approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to merge this to unstable and then deploy and confirm that the error is vanquished.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 29, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Jan 29, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a4fcf60

mergify bot added a commit that referenced this pull request Jan 29, 2024
@mergify
Merge of #5135
ac66cb5
This was referenced Jan 29, 2024
Closed
Merged
Merged
Merged
Merged
@mergify mergify bot merged commit a4fcf60 into sigp:unstable Jan 30, 2024
29 checks passed
@michaelsproul michaelsproul mentioned this pull request Jan 30, 2024
Closed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
@realbigsean @danielrachi1
Increase attestation cache sizes (sigp#5135)
8345f31 
* increase observed attesters and aggregates cache sizes

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
bug Something isn't working deneb ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @michaelsproul