Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Job Caching #4750

Closed
wants to merge 6 commits into from
Closed

CI Job Caching #4750

wants to merge 6 commits into from

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Sep 19, 2023 •
edited
Loading

Issue Addressed

Experiment with CI job caching.

Proposed Changes

  • Use rust-cache for dependencies caching
    • default settings seems pretty good, details on cache key and cache directories can be found here.
    • there is quite a significant improvement on most test suite jobs - see screenshot below. Note that artifacts aren't cached for failed jobs, so the release-test-ubuntu and debug-test-ubuntu numbers could get better once they pass.
  • Replace usage of cargo install with cargo binstall
    • reduces cargo-udeps install time from 9m to 4s.

Screenshot 2023-09-19 at 12 30 52

@jimmygchen jimmygchen added infra-ci ready-for-review The code is ready for review and removed do-not-merge labels Sep 19, 2023
jxs
jxs approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this Jimmy!

@jimmygchen
Copy link
Member Author

Thanks for reviewing @jxs - I'm going to label this as don't merge for now as the changes in #4755 also contains some caching so we may not need all changes in this PR.

@jimmygchen
Merge branch 'unstable' into rust-cache
b5e9192 
# Conflicts:
#	consensus/types/Cargo.toml
@jimmygchen
Copy link
Member Author

Closing this PR as both caching and binstall changes are covered under #4755 🎉

@jimmygchen jimmygchen closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
do-not-merge infra-ci ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @jxs