[Merged by Bors] - validator client: start http api before genesis #4714
Conversation
jxs
force-pushed
the
start-http-before-genesis
branch
from
f154366 to
aebe3dd
Compare
validator_client/src/lib.rs
Outdated
| @@ -611,6 +609,9 @@ impl<T: EthSpec> ProductionValidatorClient<T> { | |||
| ); | |||
| } | |||
|
|
|||
| // Wait until genesis has occurred. | |||
| wait_for_genesis(&self.beacon_nodes, self.genesis_time, &self.context).await?; | |||
There was a problem hiding this comment.
We also start all the other services like the block_service/etc. I haven't had time to run this PR, but if someone (@antondlr) can confirm that these services run without errors prior to genesis I think we can merge.
There was a problem hiding this comment.
just pushed this to all the holly VCs; looking good
There was a problem hiding this comment.
I see a CRIT Failed to poll sync committee duties
michaelsproul
added
val-client
|
@jxs If you have time would you mind adding some logic here to have the VC ignore the BN's Alternatively, we could change the status to |
Hi Michael, I put the Thanks |
|
@jxs That sounds good, but I think the el_offline issue is separate. If you look at the logs of the VCs on Holesky they're logging constant warnings about the BN not being synced due to el_offline=true. I figured we could roll a fix into this PR so that we have a version with cleaner logs that people can run if they're interested |
|
I implemented a quick fix for the I'll test our PRs together and then we can merge them (assuming CI recovers from the mess it's in). |
michaelsproul
added
ready-for-merge
|
Thanks Michael, rerun the CI and it's now green 🎉 |
|
bors r+ |
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
|
Build failed (retrying...): |
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
|
Build failed (retrying...): |
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
|
Build failed (retrying...): |
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
## Issue Addressed On a new network a user might require importing validators before waiting until genesis has occurred. ## Proposed Changes Starts the validator client http api before waiting for genesis ## Additional Info cc @antondlr
Issue Addressed
On a new network a user might require importing validators before waiting until genesis has occurred.
Proposed Changes
Starts the validator client http api before waiting for genesis
Additional Info
cc @antondlr