Sign BlsToExecutionChange w/ GENESIS_FORK_VERSION #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh actually I think we do need to change this in order to comply with the gossip validation change -> We need to not penalize peers at all if we match on this error |
|
Also this looks like it will reject local |
realbigsean
reviewed
Jan 13, 2023
| @@ -1217,11 +1217,13 @@ impl<T: BeaconChainTypes> Worker<T> { | |||
| ); | |||
| self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Reject); | |||
There was a problem hiding this comment.
I think we similarly need to change this to MessageAcceptance::Ignore on BeaconChainError::BlsToExecutionChangeBadFork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
GENESIS_FORK_VERSIONto signBLSToExecutionChangemessage ethereum/consensus-specs#3206Additional Info
We appear to have already implemented the new gossip validation condition. Not sure where the spec tests are though.. will look and add to this PR.