[Merged by Bors] - Add mainnet merge values 🐼 #3462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
work-in-progress
paulhauner
added a commit
that referenced
this pull request
Aug 12, 2022
commit b3c7d8e Author: Paul Hauner <[email protected]> Date: Fri Aug 12 09:57:27 2022 +1000 Add tentative merge values
paulhauner
force-pushed
the
mainnet-merge
branch
from
b3c7d8e to
a781220
Compare
paulhauner
added
ready-for-review
|
We're going to wait for the ACD call on 2022-08-18 before we cut a release with these parameters, but considering that ethereum/consensus-specs#2969 is merged I think it's a good time for us to get this into |
michaelsproul
approved these changes
Aug 16, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
## Issue Addressed NA ## Proposed Changes Adds **tentative** values for the merge TTD and Bellatrix as per ethereum/consensus-specs#2969 ## Additional Info - ~~Blocked on ethereum/consensus-specs#2969
michaelsproul
added
ready-for-merge
|
Build failed: |
|
@paulhauner we need to update the hardcoded values in |
Fixed! I had to fix some other tests that were assuming an Altair epoch that was higher than the Bellatrix epoch, too. |
|
I'm going to try adding these tests now: https://github.com/ethereum/consensus-specs/releases/tag/v1.2.0-rc.2 |
|
I had to make sure that the |
|
... and ignore some new tests: c19ab1f |
michaelsproul
approved these changes
Aug 17, 2022
Co-authored-by: Michael Sproul <[email protected]>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
## Issue Addressed NA ## Proposed Changes Adds **tentative** values for the merge TTD and Bellatrix as per ethereum/consensus-specs#2969 ## Additional Info - ~~Blocked on ethereum/consensus-specs#2969
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Adds **tentative** values for the merge TTD and Bellatrix as per ethereum/consensus-specs#2969 ## Additional Info - ~~Blocked on ethereum/consensus-specs#2969
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed NA ## Proposed Changes Bump versions to v3.0.0 ## Additional Info - ~~Blocked on sigp#3439~~ - ~~Blocked on sigp#3459~~ - ~~Blocked on sigp#3463~~ - ~~Blocked on sigp#3462~~ - ~~Requires further testing~~ Co-authored-by: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Adds tentative values for the merge TTD and Bellatrix as per ethereum/consensus-specs#2969
Additional Info
Blocked on Merge mainnet ttd and bellatrix values ethereum/consensus-specs#2969