Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Document Homebrew package #2885

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Document Homebrew package #2885

wants to merge 2 commits into from

Conversation

riptl
Copy link
Contributor

@riptl riptl commented Dec 26, 2021 •
edited
Loading

Issue Addressed

Resolves #2329

Proposed Changes

Documents the recently added lighthouse Homebrew formula.

Additional Info

NA

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@divagant-martian
Copy link
Collaborator

Thanks for your contribution @terorie!

Right now, every installation mode described in the book (binaries for various platforms + docker + source) are maintained by the lighthouse team. Under the same strategy, I'd argue in favor of moving the Homebrew chapter to Community maintained installers with an entry for homebrew. It would be good too adding a direct link to the formula's page so that users can check the target platform for this installer directly where it is documented.

Let me know what you think

@riptl
Copy link
Contributor Author

riptl commented Dec 28, 2021

Under the same strategy, I'd argue in favor of moving the Homebrew chapter to Community maintained installers with an entry for homebrew.

Makes sense, will do 👍🏻

It would be good too adding a direct link to the formula's page so that users can check the target platform for this installer directly where it is documented.

The PR already has links to https://formulae.brew.sh/formula/lighthouse and the source, is this okay?

michaelsproul
michaelsproul approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelsproul
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Jan 7, 2022

👎 Rejected by PR status

michaelsproul
michaelsproul requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, could you please rebase on unstable and change the target branch to unstable? 🙏

@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Jan 7, 2022
Document Homebrew package
3a8ad6d 
Resolves sigp#2329

Documents the recently added `lighthouse` Homebrew formula.
@riptl riptl force-pushed the homebrew-package branch from 5952c08 to 3a8ad6d Compare January 7, 2022 23:49
@riptl riptl changed the base branch from stable to unstable January 7, 2022 23:49
@riptl
Copy link
Contributor Author

riptl commented Jan 7, 2022

@michaelsproul Yes, sir! Done

michaelsproul
michaelsproul reviewed Jan 8, 2022
View reviewed changes
book/src/homebrew.md Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

bors r+

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 8, 2022
bors bot pushed a commit that referenced this pull request Jan 8, 2022
@riptl @michaelsproul
Document Homebrew package (#2885)
65b1374 
## Issue Addressed

Resolves #2329

## Proposed Changes

Documents the recently added `lighthouse` Homebrew formula.

## Additional Info

NA


Co-authored-by: Richard Patel <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
@bors
Copy link

bors bot commented Jan 8, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Document Homebrew package [Merged by Bors] - Document Homebrew package Jan 8, 2022
@bors bors bot closed this Jan 8, 2022
@riptl riptl deleted the homebrew-package branch January 8, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apple Silicon M1 support?
4 participants
@riptl @CLAassistant @divagant-martian @michaelsproul