-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Upgrade dependencies #2513
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah I agree I think its fine. There may be a discv5 update soon. I'll ensure to make sure discv5 targets latest libp2p releases. It will just be a matter of timing then. |
paulhauner
approved these changes
Aug 16, 2021
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2021
## Proposed Changes * Consolidate Tokio versions: everything now uses the latest v1.10.0, no more `tokio-compat`. * Many semver-compatible changes via `cargo update`. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0 * Many semver incompatible upgrades via `cargo upgrades` and `cargo upgrade --workspace pkg_name`. Notable ommissions: - Prometheus, to be handled separately: #2485 - `rand`, `rand_xorshift`: the libsecp256k1 package requires 0.7.x, so we'll stick with that for now - `ethereum-types` is pinned at 0.11.0 because that's what `web3` is using and it seems nice to have just a single version ## Additional Info We still have two versions of `libp2p-core` due to `discv5` depending on the v0.29.0 release rather than `master`. AFAIK it should be OK to release in this state (cc @AgeManning )
Pull request successfully merged into unstable. Build succeeded: |
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Aug 27, 2021
## Proposed Changes * Consolidate Tokio versions: everything now uses the latest v1.10.0, no more `tokio-compat`. * Many semver-compatible changes via `cargo update`. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0 * Many semver incompatible upgrades via `cargo upgrades` and `cargo upgrade --workspace pkg_name`. Notable ommissions: - Prometheus, to be handled separately: sigp#2485 - `rand`, `rand_xorshift`: the libsecp256k1 package requires 0.7.x, so we'll stick with that for now - `ethereum-types` is pinned at 0.11.0 because that's what `web3` is using and it seems nice to have just a single version ## Additional Info We still have two versions of `libp2p-core` due to `discv5` depending on the v0.29.0 release rather than `master`. AFAIK it should be OK to release in this state (cc @AgeManning )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
tokio-compat
.cargo update
. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0cargo upgrades
andcargo upgrade --workspace pkg_name
. Notable ommissions:rand
,rand_xorshift
: the libsecp256k1 package requires 0.7.x, so we'll stick with that for nowethereum-types
is pinned at 0.11.0 because that's whatweb3
is using and it seems nice to have just a single versionAdditional Info
We still have two versions of
libp2p-core
due todiscv5
depending on the v0.29.0 release rather thanmaster
. AFAIK it should be OK to release in this state (cc @AgeManning )