[Merged by Bors] - Add SensitiveUrl to redact user secrets from endpoints
#2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
the
waiting-on-author
michaelsproul
approved these changes
May 4, 2021
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 4, 2021
## Issue Addressed #2276 ## Proposed Changes Add the `SensitiveUrl` struct which wraps `Url` and implements custom `Display` and `Debug` traits to redact user secrets from being logged in eth1 endpoints, beacon node endpoints and metrics. ## Additional Info This also includes a small rewrite of the eth1 crate to make requests using `Url` instead of `&str`. Some error messages have also been changed to remove `Url` data.
|
ah, merge conflict. I'll cancel this and let the audit fix go through first bors r- |
|
Canceled. |
|
let's try it bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 4, 2021
## Issue Addressed #2276 ## Proposed Changes Add the `SensitiveUrl` struct which wraps `Url` and implements custom `Display` and `Debug` traits to redact user secrets from being logged in eth1 endpoints, beacon node endpoints and metrics. ## Additional Info This also includes a small rewrite of the eth1 crate to make requests using `Url` instead of `&str`. Some error messages have also been changed to remove `Url` data.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
SensitiveUrl to redact user secrets from endpointsSensitiveUrl to redact user secrets from endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#2276
Proposed Changes
Add the
SensitiveUrlstruct which wrapsUrland implements customDisplayandDebugtraits to redact user secrets from being logged in eth1 endpoints, beacon node endpoints and metrics.Additional Info
This also includes a small rewrite of the eth1 crate to make requests using
Urlinstead of&str.Some error messages have also been changed to remove
Urldata.