[Merged by Bors] - Fix default implementation on FixedVector #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-merge
|
bors r+ |
paulhauner
added
bug
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2021
## Issue Addressed NA ## Proposed Changes Whilst hacking on something I noticed that the default implementation of `FixedVector` can violate the length constraint! E.g., `let v: FixedVector<u8; U4> = <_>::default()` would create a fixed vector with length 0, even though it promises to *always* have length 4! This causes SSZ deserialization to fail and probably other things too. This isn't a security risk as it can't be triggered externally, however it's a foot gun for LH devs. ## Additional Info NA
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Whilst hacking on something I noticed that the default implementation of
FixedVectorcan violate the length constraint!E.g.,
let v: FixedVector<u8; U4> = <_>::default()would create a fixed vector with length 0, even though it promises to always have length 4! This causes SSZ deserialization to fail and probably other things too.This isn't a security risk as it can't be triggered externally, however it's a foot gun for LH devs.
Additional Info
NA