Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - v1.2.1 #2263

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - v1.2.1 #2263

wants to merge 7 commits into from
+51 −48

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Mar 17, 2021 •
edited
Loading

Issue Addressed

NA

Proposed Changes

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Mar 17, 2021
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 17, 2021
michaelsproul
michaelsproul approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 17, 2021
@paulhauner
v1.2.1 (#2263)
842279d 
## Issue Addressed

NA

## Proposed Changes

Bump version.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 17, 2021

Build failed:

@michaelsproul
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Mar 17, 2021
@paulhauner
v1.2.1 (#2263)
fa8e28a 
## Issue Addressed

NA

## Proposed Changes

Bump version.

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 18, 2021

Build failed:

@paulhauner
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Mar 18, 2021
@paulhauner
v1.2.1 (#2263)
ed0a27f 
## Issue Addressed

NA

## Proposed Changes

Bump version.

## Additional Info

NA
@michaelsproul
Copy link
Member

In the 2nd run, it failed with this error:

2021-03-17T23:34:52.0585839Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Get head via http failed: Reqwest(reqwest::Error { kind: Request, url: Url { scheme: \"http\", username: \"\", password: None, host: Some(Ipv4(127.0.0.1)), port: Some(35809), path: \"/eth/v1/beacon/states/head/finality_checkpoints\", query: None, fragment: None }, source: TimedOut })"', testing/simulator/src/no_eth1_sim.rs:161:41

As far as I can tell we don't even have timeouts set up on reqwest so I'm not sure where this is coming from. Will investigate further.

@bors
Copy link

bors bot commented Mar 18, 2021

Build failed:

@paulhauner
Copy link
Member Author

I just realised we need to update Prater boot nodes. I'll do that, please don't merge until then.

@michaelsproul michaelsproul mentioned this pull request Mar 18, 2021
Closed
@paulhauner
Copy link
Member Author

Boot ENR added, happy to merge now.

@paulhauner paulhauner mentioned this pull request Mar 18, 2021
Closed
@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 18, 2021
@paulhauner
v1.2.1 (#2263)
b34a79d 
## Issue Addressed

NA

## Proposed Changes

- Bump version.
- Add some new ENR for Prater
    - Afri: eth-clients/eth2-networks#42
    - Prysm: eth-clients/eth2-networks#43
- Apply the fixes from #2181 to the no-eth1-sim to try fix CI issues. 

## Additional Info

NA
@bors
Copy link

bors bot commented Mar 18, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title v1.2.1 [Merged by Bors] - v1.2.1 Mar 18, 2021
@bors bors bot closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulhauner @michaelsproul