Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Version bump milagro_bls to v1.4.2 #2261

Closed
wants to merge 2 commits into from

Conversation

kirk-baird
Copy link
Member

Issue Addressed

n/a

Proposed Changes

Bump the version of milagro_bls to version v1.4.2

Additional Info

No breaking changes.

Signed-off-by: Kirk Baird <[email protected]>
Cargo.lock Outdated
@@ -1632,8 +1632,7 @@ checksum = "212d0f5754cb6769937f4501cc0e67f4f4483c8d2c3e1e922ee9edbe4ab4c7c0"
[[package]]
name = "discv5"
version = "0.1.0-beta.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f6f52d2228d51e8f868a37d5b5b25b82c13552b635d5b47c3a5d53855a6fc4f0"
source = "git+https://github.com/sigp/discv5?rev=02d2c896c66f8dc2b848c3996fedcd98e1dfec69#02d2c896c66f8dc2b848c3996fedcd98e1dfec69"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change might have been caused by an old version of cargo, but we'll see if the Cargo.lock check on CI is happy

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, it failed (https://github.com/sigp/lighthouse/pull/2261/checks?check_run_id=2117512080)

If you update Rust to 1.50 and do make lint that should update Cargo.lock accordingly

@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Mar 16, 2021
Signed-off-by: Kirk Baird <[email protected]>
@kirk-baird
Copy link
Member Author

Ah yeah, it failed (https://github.com/sigp/lighthouse/pull/2261/checks?check_run_id=2117512080)

If you update Rust to 1.50 and do make lint that should update Cargo.lock accordingly

Done :)

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Mar 16, 2021
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2021
## Issue Addressed

n/a

## Proposed Changes

Bump the version of `milagro_bls` to version v1.4.2

## Additional Info

No breaking changes.
@bors bors bot changed the title Version bump milagro_bls to v1.4.2 [Merged by Bors] - Version bump milagro_bls to v1.4.2 Mar 16, 2021
@bors bors bot closed this Mar 16, 2021
@michaelsproul michaelsproul deleted the milagro-v1-4-2 branch March 16, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants