[Merged by Bors] - Fix voluntary exit to work with latest beacon api #2257
Conversation
There was a problem hiding this comment.
Nice, thanks for following up on this. There's a TODO in here, which I've commented. Perhaps we could also add some sort of message telling the user that we're going to wait until the exit is accepted into the chain and it might take several minutes. Perhaps adding a message when we poll but don't break would be handy too?
| loop { | ||
| // Sleep for 1 slot duration and then check if voluntary exit was processed | ||
| // by checking the validator status. | ||
| // TODO: should we wait for longer to account for forks? |
There was a problem hiding this comment.
TODO
Perhaps we just update the "Voluntary exit has been accepted..." text to say something along the lines of:
"Voluntary exit has been accepted into the beacon chain, but not yet finalized. Finalization may take several minutes or longer. Before finalization there is a low probability that the exit may be reverted."
There was a problem hiding this comment.
Yep, this sounds perfect. Will make the changes.
paulhauner
added
the
waiting-on-author
paulhauner
added
ready-for-merge
## Issue Addressed Also fixes #1932 ## Proposed Changes Use `ValidatorStatus::ActiveOngoing` instead of `ValidatorStatus::Active` to filter active validators. Prints extra information regarding successful voluntary exit.
|
I'll batch this bors r- |
|
Canceled. |
|
bors r+ |
## Issue Addressed Also fixes #1932 ## Proposed Changes Use `ValidatorStatus::ActiveOngoing` instead of `ValidatorStatus::Active` to filter active validators. Prints extra information regarding successful voluntary exit.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Issue Addressed
Also fixes #1932
Proposed Changes
Use
ValidatorStatus::ActiveOngoinginstead ofValidatorStatus::Activeto filter active validators.Prints extra information regarding successful voluntary exit.