[Merged by Bors] - Release candidate v1.2.0-rc.0 #2248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed Changes Supranational just made a `blst` 0.3.3 release, so I figure we may as well include it for v1.2.0
…#2247) This is a small PR which prevents unwanted bootnodes from being added to the DHT and being dialed when the `--disable-discovery` flag is set. The main reason one would want to disable discovery is to connect to a fix set of peers. Currently, regardless of what the user does, Lighthouse will populate its DHT with previously known peers and also fill it with the spec's bootnodes. It will then dial the bootnodes that are capable of being dialed. This prevents testing with a fixed peer list. This PR prevents these excess nodes from being added and dialed if the user has set `--disable-discovery`.
michaelsproul
added
blocked
ready-for-review
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
Prepare for v1.2.0 with this release candidate. To be merged after #2247 and #2246 Co-authored-by: Age Manning <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
michaelsproul
added a commit
that referenced
this pull request
Mar 10, 2021
Prepare for v1.2.0 with this release candidate. To be merged after #2247 and #2246 Co-authored-by: Age Manning <[email protected]>
michaelsproul
added a commit
that referenced
this pull request
Mar 10, 2021
This reverts commit 9b51b41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for v1.2.0 with this release candidate.
To be merged after #2247 and #2246