-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator services adjust with system time #2162
Conversation
You should be able to fix the clippy lints by merging in |
Just checking to make sure this is still a draft and not ready-for-review :) |
Sorry, I lost sight of this guy 😅 Will merge unstable and do some more testing on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. There's also another timer here:
interval.tick().await; |
I haven't had a chance to check out the simulator with 1s slot times, but I'll check that out once these comments are addressed :)
Just double-checking that this isn't ready for review :) |
Sorry forgot to mark it. It is ready for review! |
I'm really keen to get this merged @pawanjay176, it looks great, but @paulhauner just went and revamped the whole duties service in the meantime 😩 There's a user on Discord who needs this PR, I think.. |
I can take care of merging this down once we get my optimise PR in :) |
Closing this since I merged it into #2243. Thanks for your work @pawanjay176! |
Issue Addressed
Fixes #2052
Proposed Changes
Instead of running a repeated interval timer, the duties, attestation and fork services sleep for the required duration until the next slot/epoch and then run spawn their respective tasks.