Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Revert "add a github action for build multi-arch docker images (#1574)" #1591

Closed
wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

This reverts commit 2627463.

Issue Addressed

This is a temporary fix for #1589, by reverting #1574. The Docker image needs to be built with --build-arg PORTABLE=true, and we could probably integrate that into the multi-arch build, but in the interests of expediting a fix, this PR opts for a revert.

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Sep 6, 2020
@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2020
…" (#1591)

This reverts commit 2627463.

## Issue Addressed

This is a temporary fix for #1589, by reverting #1574. The Docker image needs to be built with `--build-arg PORTABLE=true`, and we could probably integrate that into the multi-arch build, but in the interests of expediting a fix, this PR opts for a revert.
@bors bors bot changed the title Revert "add a github action for build multi-arch docker images (#1574)" [Merged by Bors] - Revert "add a github action for build multi-arch docker images (#1574)" Sep 6, 2020
@bors bors bot closed this Sep 6, 2020
@michaelsproul michaelsproul deleted the revert-docker-multi-arch branch September 6, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants