Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node health endpoint #4292

Closed
michaelsproul opened this issue May 15, 2023 · 2 comments
Closed

Update node health endpoint #4292

michaelsproul opened this issue May 15, 2023 · 2 comments
Assignees
@eserilev
Labels
HTTP-API

Comments

@michaelsproul
Copy link
Member

Description

As suggested by @jmcruz1983 here we should update the /eth/v1/node/health endpoint to account for the execution node's sync status.

I think we should change the semantics to return syncing if:

let unhealthy = syncing || el_offline || optimistic

Currently it's just checking the BN's sync status.

Additional Info

Related to #4291, which will add the el_offline field.
@eserilev
Copy link
Collaborator

i'd like to pick this one up

@michaelsproul
Copy link
Member Author

thanks @eserilev! let us know if you need any pointers

the EL offline methods added in #4291 can probably be used for the el_offline part

@eserilev eserilev mentioned this issue May 21, 2023
Closed
bors bot pushed a commit that referenced this issue Jun 30, 2023
@eserilev
Update node health endpoint (#4310)
826e090 
## Issue Addressed

[#4292](#4292)

## Proposed Changes

Updated the node health endpoint

will return a 200 status code if  `!syncing && !el_offline && !optimistic`

wil return a 206 if `(syncing || optimistic) &&  !el_offline`

will return a 503 if `el_offline`



## Additional Info
ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
@eserilev
Update node health endpoint (sigp#4310)
a255c24 
## Issue Addressed

[sigp#4292](sigp#4292)

## Proposed Changes

Updated the node health endpoint

will return a 200 status code if  `!syncing && !el_offline && !optimistic`

wil return a 206 if `(syncing || optimistic) &&  !el_offline`

will return a 503 if `el_offline`



## Additional Info
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@eserilev @Woodpile37
Update node health endpoint (sigp#4310)
fd18cef 
## Issue Addressed

[sigp#4292](sigp#4292)

## Proposed Changes

Updated the node health endpoint

will return a 200 status code if  `!syncing && !el_offline && !optimistic`

wil return a 206 if `(syncing || optimistic) &&  !el_offline`

will return a 503 if `el_offline`



## Additional Info
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@eserilev @Woodpile37
Update node health endpoint (sigp#4310)
443b415 
[sigp#4292](sigp#4292)

Updated the node health endpoint

will return a 200 status code if  `!syncing && !el_offline && !optimistic`

wil return a 206 if `(syncing || optimistic) &&  !el_offline`

will return a 503 if `el_offline`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eserilev eserilev

Labels
HTTP-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev