Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local payload comparison #3699

Closed
realbigsean opened this issue Nov 7, 2022 · 5 comments
Closed

Local payload comparison #3699

realbigsean opened this issue Nov 7, 2022 · 5 comments

Comments

@realbigsean
Copy link
Member

Description

#3517 implemented an absolute comparison of a configured value to the value in a claimed "builder bid", but once ethereum/execution-apis#307 is added, we can change the configurable value to be the margin a builder bid has to exceed the local payload by.

@pawanjay176
Copy link
Member

Related #3646

@michaelsproul
Copy link
Member

Labelling this capella as we've added the blockValue field on the capella branch but are not yet utilising it

@michaelsproul
Copy link
Member

Completed in #3934 🎉

@allboxes
Copy link

@michaelsproul @ethDreamer , does #3934 repurpose --builder-profit-threshold to allow users to set a margin by which the builder bid has to exceed the local payload? As best I could tell --builder-profit-threshold is still only used in the original separate flow comparing builder block value to a fixed block value. If that's the case could this be reopened to make --builder-profit-threshold (or a new flag) a margin by which the remote block value has to exceed to local block value?

@ethDreamer
Copy link
Member

@michaelsproul @ethDreamer , does #3934 repurpose --builder-profit-threshold to allow users to set a margin by which the builder bid has to exceed the local payload? As best I could tell --builder-profit-threshold is still only used in the original separate flow comparing builder block value to a fixed block value. If that's the case could this be reopened to make --builder-profit-threshold (or a new flag) a margin by which the remote block value has to exceed to local block value?

Correct, I hadn't repurposed the flag yet. I'll have to add that as well. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants